Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ios positions when none passed in #299

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix ios positions when none passed in #299

merged 1 commit into from
Jun 2, 2020

Conversation

Gillardo
Copy link
Contributor

@Gillardo Gillardo commented Jun 2, 2020

Updated to check if positions passed in, like when using ionic-native

#290

@Gillardo
Update FileOpener2.m
26962a4 
Updated to check if positions passed in
@Gillardo Gillardo mentioned this pull request Jun 2, 2020
Merged
@pwlin pwlin merged commit 11b5db2 into pwlin:master Jun 2, 2020
@Gillardo
Copy link
Contributor Author

Gillardo commented Jun 2, 2020

Cheers bud. Can u publish latest version to npm please?

@pwlin
Copy link
Owner

pwlin commented Jun 2, 2020

@Gillardo just pushed version 3.0.2 to npm. Can you please test if it works?

@Gillardo
Copy link
Contributor Author

Gillardo commented Jun 3, 2020

works great, thanks bud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gillardo @pwlin